Remove unused map iter_by_pix and iter_by_coord methods #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to say: these methods were added in #1093 as part of a very large code addition (2500 lines) to Gammapy, and it wasn't discussed at all. |
registerrier
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the map iter_by_pix and iter_by_coord methods.
They are unused in Gammapy, no use case has come up for this so far. The use case given in the docs could just as well and much more efficiently be written by using the whole map directly, or by using
iter_by_image.Iterating over pixels in Python will never be efficient, should always be avoided. Almost all computations can be expressed using Numpy, and should that not be possible, one could use Numba or Cython, or if really needed, do this Python pixel loop where it's needed.
IMO we shouldn't leave such code in Gammapy, but start to either remove or improve quality as we work towards Gammapy v1.0. Note that this code is non-trivial and likely not very well written. E.g. the docstring of
unpack_seqsays that it is probably not needed in Python 3. Also the implementation of the pixel loop containslist(self.geom.get_coord(flat=True)), i.e. a Python list of all pixel coords is made, which takes a lot of memory. If a generator pixel iter were kept, it should not contain such a list inside. So the question is really: OK to remove? Or spend effort to improve before v1.0?@registerrier @adonath - Thoughts?